Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starred playlist support #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

starred playlist support #30

wants to merge 1 commit into from

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 26, 2013

Support for getting the special "starred" playlist, session.getStarred().

@LinusU
Copy link
Contributor Author

LinusU commented Sep 26, 2013

Just saw that you made some slight refactoring to the tests, will updated and push within 5 minutes :)

@LinusU
Copy link
Contributor Author

LinusU commented Sep 26, 2013

Oh fuck, I really screwed this up, will try to rebase on your master...

@LinusU
Copy link
Contributor Author

LinusU commented Sep 26, 2013

Success! I've run all the tests locally and it should be good to merge.

@Floby
Copy link
Owner

Floby commented Sep 26, 2013

Looks good to me.
I'm wondering if it's a good testing practice to assume the currently logged in user will have starred at least one track.

@LinusU
Copy link
Contributor Author

LinusU commented Sep 26, 2013

True, do you want me to remove that line?

@Floby
Copy link
Owner

Floby commented Sep 26, 2013

No, that's a good test. Maybe we should star a track before that.

On 26 September 2013 11:33, Linus Unnebäck [email protected] wrote:

True, do you want me to remove that line?


Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-25154573
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants